[JENKINS-31256] Use credentials in waitForServerToBack #67
Conversation
This address three regressions introduced with HUDSON-4071, 662b0f and JENKINS-6167 as these only modified run() resulting in no proxy and no authorization support in waitForServerToBack()
|
Thank you for this pull request! Please check this document for how the Jenkins project handles pull requests. |
|
👍 . I wonder why remoting supports only Basic auth, but It's another story. Maybe makes sense to move the duplicated credentials handling code to a new helper method. |
|
Any further comments or can this be merged? |
|
Uhm, last changes caused a merge conflict. I'm planning a new release soon, so I'll check what can be done with this guy |
…Back # Conflicts: # src/main/java/hudson/remoting/Engine.java
|
I fixed the merge conflict but I think the SSL stuff has also to go to waitForServerToBack(). I think some parts can be commonized into openURLConnection(). I'll take a closer look shortly. |
…in waitForServerToBack()
+1 |
|
Needs to be merged locally. NVM, I'll do it |
|
Any ETA on this landing? |
|
Sorry for the delay. I'll try to do it ASAP |
| SSLSocketFactory sslSocketFactory = null; | ||
| try { | ||
| sslSocketFactory = getSSLSocketFactory(); | ||
| } catch (Throwable e) { |
There was a problem hiding this comment.
This approach is being used in other places of this file. It is not LGTM, but it does not increase the technical debt
|
Merged via #87 |
This patch addresses three regressions introduced with HUDSON-4071, 662b0f and JENKINS-6167 as these only modified run() resulting in no proxy and no authorization support in waitForServerToBack()
As a result the connection to the master could not be reestablished as connections were rejected with response code 401 as reported in JENKINS-31256.