Clean up "slave" term from documentation. #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Where possible remove the term "slave" from documentation, replacing with "agent" as needed. In some instances, both were used but we're past the time where we need to continue using the old name. Removes from AsciiDoc pages, JavaDoc, and code comments. The remaining documentation references are for external or remaining API references.
oleg-nenashev
approved these changes
Oct 28, 2019
| @@ -6,7 +6,7 @@ Jenkins Remoting layer | |||
|
|
|||
| Jenkins remoting is an executable JAR, | |||
| which implements communication layer in [Jenkins](https://jenkins.io) automation server. | |||
| It's being used for master <=> agent(fka "slave") and master <=> CLI communications. | |||
There was a problem hiding this comment.
I think it still makes sense to mention it here. We can amend it somehow to be explicit that the term is discouraged
There was a problem hiding this comment.
I thought about it, but I don't think we need to maintain this mention here. We could add it as a footnote somewhere. I've thought about trying to clean up the documentation some. I could add a note in there somewhere.
It's been quite a while since the terminology change and there are no shortage of places that mention that agents used to be known as slaves. Probably don't need to keep this one.
jvz
approved these changes
Oct 28, 2019
jeffret-b
added
chore
|
Let's make sure this builds before proceeding. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Where possible remove the term "slave" from documentation, replacing with "agent" as needed. In some instances, both were used but we're past the time where we need to continue using the old name.
Removes from AsciiDoc pages, JavaDoc, and code comments.
The remaining documentation references are for external or remaining API references.