Annotate methods which return explicit null #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I forgot about @reviewbybees |
|
This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation. |
abayer
approved these changes
Jul 10, 2017
| @@ -139,6 +140,7 @@ public int getPriority() { | |||
| * @deprecated Used in 2.x now replaced with dynamic {@link JobGroup#jobGroupStrategy}, will return the view | |||
| */ | |||
| @Deprecated | |||
| @CheckForNull | |||
| @@ -236,7 +238,8 @@ private PriorityConfigurationCallback getPriorityInternal(Queue.Item item, Prior | |||
| return priorityCallback.setPrioritySelection(PrioritySorterConfiguration.get().getStrategy().getDefaultPriority()); | |||
| } | |||
|
|
|||
| public JobGroup getJobGroup(PriorityConfigurationCallback priorityCallback, Job<?, ?> job) { | |||
| @CheckForNull | |||
|
@abayer As a plugin maintainer I have officially gave up with maintaining tab indenting in it. Once I have zero pending PRs, I will just refactor all the code |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a risk of NPEs in some cases, e.g. in "*Strategy#getPriority()" API. No related JIRA issues, but I would rather fix it.