feat:Remove inline javascript code from BuoldTriggerStep

jenkinsci · Oct 9, 2023 · 4bf9d68 · 4bf9d68
1 parent 2239584
commit 4bf9d68
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 13 deletions.
diff --git a/...esources/org/jenkinsci/plugins/workflow/support/steps/build/BuildTriggerStep/config.jelly b/...esources/org/jenkinsci/plugins/workflow/support/steps/build/BuildTriggerStep/config.jelly
@@ -44,19 +44,7 @@ THE SOFTWARE.
     <f:entry field="parameters" title="Parameters">
         <div id="params"/>
         <script>
-            function loadParams() {
-                var div = document.getElementById('params');
-                fetch('${descriptor.descriptorUrl}/parameters?job=' + encodeURIComponent(document.getElementById('${jobFieldId}').value) + '&amp;context=${descriptor.contextEncoded}').then((rsp) => {
-                    rsp.text().then((responseText) => {
-                        if (rsp.ok) {
-                            div.innerHTML = responseText;
-                            Behaviour.applySubtree(div);
-                        } else {
-                            div.innerHTML = "<b>ERROR</b>: Failed to load parameter definitions: " + rsp.statusText;
-                        }
-                    });
-                });
-            }
+            <st:adjunct includes="org.jenkinsci.plugins.workflow.support.steps.build.BuildTriggerStep.config"/>
         </script>
     </f:entry>
 </j:jelly>
diff --git a/...n/resources/org/jenkinsci/plugins/workflow/support/steps/build/BuildTriggerStep/config.js b/...n/resources/org/jenkinsci/plugins/workflow/support/steps/build/BuildTriggerStep/config.js
@@ -0,0 +1,13 @@
+function loadParams() {
+    var div = document.getElementById('params');
+    fetch('${descriptor.descriptorUrl}/parameters?job=' + encodeURIComponent(document.getElementById('${jobFieldId}').value) + '&amp;context=${descriptor.contextEncoded}').then((rsp) => {
+        rsp.text().then((responseText) => {
+            if (rsp.ok) {
+                div.innerHTML = responseText;
+                Behaviour.applySubtree(div);
+            } else {
+                div.innerHTML = "<b>ERROR</b>: Failed to load parameter definitions: " + rsp.statusText;
+            }
+        });
+    });
+}