Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JENKINS-71479] Do not use SCSS lighten function directly to avoid invalid CSS #8425

Merged
merged 1 commit into from
Aug 24, 2023
Merged

[JENKINS-71479] Do not use SCSS lighten function directly to avoid invalid CSS #8425

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions war/src/main/scss/abstracts/_theme.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,8 +116,8 @@ $semantics: (
// Deprecated - Button primary
--button-color--primary: var(--background);
--btn-primary-bg: #063f61;
--btn-primary-bg-hover: lighten(#063f61, 7.5%);
--btn-primary-bg-active: lighten(#063f61, 12%);
--btn-primary-bg-hover: #{lighten(#063f61, 7.5%)};
--btn-primary-bg-active: #{lighten(#063f61, 12%)};
Comment on lines +119 to +120
Copy link
Member Author

@dwnusbaum dwnusbaum Aug 23, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am far from an SCSS expert, so IDK whether this is the right way to do things, but it does fix the issue.

// Deprecated - Button primary
--btn-secondary-color: var(--secondary);
--btn-secondary-bg: var(--btn-text-color);
Expand Down
Loading