-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JENKINS-62889] ParameterDefinition check for validity #4826
Conversation
Add a simple API to ParameterDefinition by which a caller can validate a ParameterValue for that specific definition.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed prior.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you plan to file a PR or ticket to fix graphql-server-plugin after removing these classes? It would be appreciated.
Co-authored-by: stellargo <sumitsarinofficial@gmail.com>
We've got sufficient approvals and passing builds so I'm going to mark this as ready-for-merge and let the waiting period begin. |
Add an API to ParameterDefinition by which a caller can validate a ParameterValue for that specific definition. This provides a mechanism to ensure that users cannot inject unrecognized values. This is particularly useful for things like ChoiceParameterDefinition, which process a value as a string, but should only allow a specific set of choices.
This new API is optional in two different ways:
JobParameterDefinition
andJobParameterValue
were never completed. These are only used in tests inMockClassUtils
in graphql-server-plugin. These should be removed as part of clean up.See JENKINS-62889.
Proposed changelog entries
N/A
Proposed upgrade guidelines
N/A
Submitter checklist
Proposed changelog entries
section only if there are breaking changes or other changes which may require extra steps from users during the upgradeDesired reviewers
@mention
Maintainer checklist
Before the changes are marked as
ready-for-merge
:Proposed changelog entries
are correctupgrade-guide-needed
label is set and there is aProposed upgrade guidelines
section in the PR title. (example)lts-candidate
to be considered (see query).