Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INFRA-1032] ${user.name} might contain metacharacters #2929

Merged
merged 1 commit into from
Jun 28, 2017

Conversation

jglick
Copy link
Member

@jglick jglick commented Jun 26, 2017

Replaces #2716 with the same fix as in jenkinsci/remoting#173.

@reviewbybees

@ghost
Copy link

ghost commented Jun 26, 2017

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐝

@jglick
Copy link
Member Author

jglick commented Jun 26, 2017

Working so far:

[INFO] Setting property 'build.version' to '2.68-SNAPSHOT (private-06/26/2017 19:29 GMT-win2012-b5ff00$)'.

@rtyler
Copy link
Member

rtyler commented Jun 26, 2017

@jglick Just thinking aloud here, but is there a reason that regex-property stuff shouldn't go into the parent pom?

@jglick
Copy link
Member Author

jglick commented Jun 26, 2017

Parent POM as in jenkins/pom? It could I guess, though for plugins we already have this code which is better as it includes a Git commit hash as well as the user.name. So since jenkins and remoting both handle build numbers, pulling it up into the parent would only benefit other non-plugin/module components TBD which opted in to the feature.

@rtyler
Copy link
Member

rtyler commented Jun 26, 2017

@jglick Understood, just curious.

@jglick
Copy link
Member Author

jglick commented Jun 26, 2017

@reviewbybees done

@jglick jglick added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Jun 26, 2017
@oleg-nenashev oleg-nenashev merged commit 9b4b9ff into jenkinsci:master Jun 28, 2017
@jglick jglick deleted the user.name.escaped branch June 28, 2017 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants