[JENKINS-71677] Remove usages of Prototype

[balakine]

This change removes Prototype.js usages from the plugin, replacing them with native javascript methods.

Testing done

Creating new charts, changing config of existing charts, reordering charts, and deleting charts have been manually tested. No functionality differences have been observed, no error in console, no unhandled exceptions.

Submitter checklist

Beta Give feedback

1. Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
2. Ensure that the pull request title represents the desired changelog entry
3. Please describe what you did
4. Link to relevant issues in GitHub or Jira
5. Link to relevant pull requests, esp. upstream and downstream changes
6. Ensure you have provided tests - that demonstrates feature works or fixes the issue

[MarkEWaite]

Thanks very much for doing this! Don't forget to describe the interactive testing that has been performed on the changes. When replacing Prototype.js, it is important that each of the modified items has been checked interactively to confirm that the new code continues to function the same as the previous code.

[timja]

Is there anything remaining on this? I checked what I understand of this plugin and it seemed to work just as it did before.

Half the sidepanel links are broken as far as I can tell but they were broken before, and there's no reason that I can see for all the manual data binding in JavaScript, basically a lot of pre-existing issues.

The jenkins.version needs updating to at least 2.405 although I would suggest 2.414 as it's the basis of the next LTS.

[balakine]

I feel it’s close to done, I just want to add a list of manual tests to the description and review the diff one more time.

[timja]

url seems to be missing here? is that intentional?

[balakine]

param holds the url. body is missing, but it’s not provided to the function - the author calls it ‘link’ mode.

[timja]

But the function just takes a url not an object? Is param actually the url?

[balakine]

Yes, the patan is either a url or a form id. See here, for example

global-build-stats-plugin/src/main/webapp/scripts/global-build-stats/BuildStatConfigs.js

Line 136 in b9e4aaa

ajaxCall('link', rootURL+'/plugin/global-build-stats/createChartMap?buildStatId='+buildStatConfig.id, function(ret){

[timja]

Not tested the last couple of changes but I did test an older version