Adapt git browsers for Jetty 12 EE 9 transition #1620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No need to throw ServletException when checking for URL validity. IOException is sufficient and avoids including Jakarta EE in the method signature. Testing done: * Confirmed that AssemblaWeb still reports the expected message when an invalid URL is provided and that it reports no message when a valid URL is provided. Confirmed that Assembla has changed URLs and broken the browsing links that previously worked. Separate bug report * Confirmed that GitBlit browsing works as expected by installing a GitBlit server. https://hub.docker.com/r/gitblit/gitblit * Confirmed that ViewGit browser provides change links as expected. Confirmed that the ViewGit URL check logic no longer works on the site used as an example. Now reports that https://repo.or.cz/ does not look like a ViewGit site. Separate bug report Did not check Gitiles because the Gitiles source repository is archived on GitHub at https://github.com/google/gitiles . No further development is expected. Did not check TFS2013 because I have no idea where to find a Team Foundation Server 2013 installation. Did not check Fisheye because I could not find a Fisheye server on the public internet.
MarkEWaite
added
the
chore
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapt git browsers for Jetty 12 EE 9 transition
No need to throw ServletException when checking for URL validity. IOException is sufficient and avoids including Jakarta EE in the method signature.
Testing done
Did not check Gitiles because the Gitiles source repository is archived on GitHub at https://github.com/google/gitiles . No further development is expected.
Did not check TFS2013 because I have no idea where to find a Team Foundation Server 2013 installation.
Did not check Fisheye because I could not find a Fisheye server on the public internet.
Resolves one of the changes needed for Jetty 12 EE 9. More changes are noted in:
Submitter checklist