Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use /bin/sh rather than /bin/bash in test #1323

Merged
merged 1 commit into from
Sep 3, 2022

Conversation

MarkEWaite
Copy link
Contributor

@MarkEWaite MarkEWaite commented Sep 3, 2022

Use /bin/sh instead of /bin/bash in test

Fix test on Unix platforms that do not include bash by default.

Tests performed

On FreeBSD and OpenBSD (where /bin/bash is not available), I run

$ git checkout master
$ mvn clean -Dtest=GitHooksTest test
HEAD is now at e98fea9 Jenkinsfile
fatal: cannot run .git/hooks/post-checkout: No such file or directory

Using this pull request, the failing test is resolved:

$ git checkout -b use-posix-shell -t origin/use-posix-shell
$ mvn clean -Dtest=GitHooksTest test
Test passes

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that verify my changes
  • Unit tests pass locally with my changes
  • I have added documentation as necessary
  • No Javadoc warnings were introduced with my changes
  • No spotbugs warnings were introduced with my changes
  • Documentation in README has been updated as necessary
  • Online help has been added and reviewed for any new or modified fields
  • I have interactively tested my changes
  • Any dependent changes have been merged and published in upstream modules (like git-client-plugin)

Types of changes

  • Test

Fix test on Unix platforms that do not include bash by default
@github-actions github-actions bot added the test label Sep 3, 2022
@MarkEWaite MarkEWaite merged commit 3c11517 into jenkinsci:master Sep 3, 2022
@MarkEWaite MarkEWaite deleted the use-posix-shell branch September 3, 2022 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant