-
-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch JDK11, Alpine and Windows Dockerfiles to Remoting 3.35 #84
Conversation
@oleg-nenashev @jeffret-b any thoughts on this? We (I) missed to update the other Dockerfiles with the new remoting version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me. I don't use docker agents much so I can't provide meaningful feedback on that part, but moving to the latest Remoting should be fine. It makes sense to upgrade to 3.35 to get the direction connection capabilities.
These missed versions and a serious of regressions last week shows that I
need a break before I can review PRs properly. Please proceed without me
for now, I am on vacation and need some time to recover
…On Tue, Sep 24, 2019, 19:39 Alex Earl ***@***.***> wrote:
***@***.**** approved this pull request.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#84>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAW4RIAFEK7GXFKCMA6RBX3QLJGD7ANCNFSM4IZLYKGA>
.
|
@oleg-nenashev thanks. Enjoy your vacation 😊 |
PS: who can release a new docker-slave version? |
Once it's merged it should be auto built on dockerhub |
Ah, ok. Good to know. |
I'm not sure how those tags get created. |
@slide It seems Oleg switched to release-drafter 9 days ago. Before he created the tags manually. I guess owners of the repo should see a new draft release?
|
@oleg-nenashev In #74 I missed to adjust the other Dockerfiles as well 😕
Sorry for that.