Drop global HOME environment variable #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Close and reopen for build |
slide
approved these changes
Aug 8, 2019
|
i will do a new release once we have a new Remoting version. CC @jeffret-b |
|
I'm hoping to get a new Remoting version out the first half of next week. |
lemeurherve
pushed a commit
to lemeurherve/docker-agent
that referenced
this pull request
Nov 27, 2023
…riable-if-set if java home is defined, use it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HOME is normally controlled by the "system"[1] and should match what the user's home directory in
/etc/passwdis. Overwriting this value withENVin this docker image causes some surprises when the user is changes withUSERin a docker image derivedFROMthis image. Unfortunatly, docker still doesn't allow to "reset" environment variables (moby/moby#3465), so if I want to change the user, I need to remember to also updateHOME.Long story short: This removes the global preset for
HOME, soHOMEdoes function as expected.[1] I think in normal UNIX sessions, login is responsible for that, but in the case of docker, docker itself takes care of that..