Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(linux) add curl #321

Merged
merged 1 commit into from
Nov 12, 2022
Merged

feat(linux) add curl #321

merged 1 commit into from
Nov 12, 2022

Conversation

dduportal
Copy link
Contributor

This PR fixes #153 but is blocked by #320 .

It adds curl on all the Linux images + the root CA certificates (to ensure any HTTPS website can be used with curl).

It also stop using curl to download the remoting: the Dockerfile directive ADD is used instead to benefit from BuildX optimization, benefit from improved caching and simplify instructions (less layers, less code and faster builds).
Please note that the ADD instruction will soon support checksum https://docs.docker.com/engine/reference/builder/#verifying-a-remote-file-checksum-add---checksumchecksum-http-src-dest.

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

…ive to download remoting

Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

curl is not installed in jnlp agent based image
2 participants