Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce the JDK8 branch (with cherry-picks and version bumps) #299

Merged
merged 8 commits into from
Oct 27, 2022

Conversation

dduportal
Copy link
Contributor

@dduportal dduportal commented Oct 22, 2022

This PR is the initial work related to #298.

From the commit 8bea7ae (last commit with JDK8 on the master branch, it introduces the following changes:

  • Cherry-picked from master:

    • cleanup: Drop PPC64 support (ppc64le)
    • feat: Bump Debian Bullseye base to 20221004
    • chore: Only deploy Docker images on git tags
  • Specific for this branch:

    • cleanup: Remove all the non JDK8 images
    • chore: Restrict deployment to git tag matching the pattern *-jdk8
  • New versions bumps:

    • feat: Bump remoting to 3028.va_a_436db_35078 (latest known version to work with JDK8)

      $ java -jar remoting-3028.va_a_436db_35078.jar -version
      3028.va_a_436db_35078
      $ java -version
      openjdk version "1.8.0_345"
      OpenJDK Runtime Environment (Temurin)(build 1.8.0_345-b01)
      OpenJDK 64-Bit Server VM (Temurin)(build 25.345-b01, mixed mode)
    • feat: Bump JDK8 to 8u345-b01

    • feat(windows): Bump git to 2.38.1 cancelled because Regression: MinGit 2.38.0 fails to execute in Windows Nano Server git-for-windows/git#4052

    • chore: Bump bats to 1.8.2 (and bats tools to latest)

dduportal and others added 3 commits October 22, 2022 10:41
Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
IBM no longer provides the PowerPC agents that we use to test and
verify PowerPC support. Can't support an architecture that we can't
test.

(cherry picked from commit 702b4b3)
Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
@dduportal dduportal changed the title Init JDK8 branch Introduce the JDK8 branch (with cherry-picks and version bumps) Oct 22, 2022
@dduportal dduportal marked this pull request as ready for review October 22, 2022 14:44
@dduportal dduportal requested a review from a team as a code owner October 22, 2022 14:44
@dduportal
Copy link
Contributor Author

Hello @basil @slide @jglick , could I have a your eyes on this PR?

I'm interested in validating the choices for the remoting version and the cherry-picked changes.

The idea of this branch comes from the feedbacks from @basil , I tried to use it for this case (last release of the JDK8)

… (to avoid overriding 'latest'-like docker tags)

Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
@dduportal
Copy link
Contributor Author

(one of the Windows builds is failing when installing git-lfs: working on it)

Copy link
Member

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK from a brief glance.

8/alpine/Dockerfile Show resolved Hide resolved
README.md Show resolved Hide resolved
tests/tests.bats Show resolved Hide resolved
Jenkinsfile Show resolved Hide resolved
Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
@dduportal dduportal requested a review from timja October 27, 2022 12:58
@dduportal dduportal merged commit c2a1cc9 into jenkinsci:jdk8 Oct 27, 2022
@dduportal dduportal deleted the jdk8 branch October 27, 2022 13:41
lemeurherve pushed a commit to lemeurherve/docker-agent that referenced this pull request Nov 27, 2023
chore(linux tests) apply shellcheck and fix concurency issues
lemeurherve pushed a commit to lemeurherve/docker-agent that referenced this pull request Jan 11, 2024
chore(linux tests) apply shellcheck and fix concurency issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants