Drop Java 8 #284
Merged
Drop Java 8 #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
slide
commented
Sep 21, 2022
•
slide
commented
- Remove java 8 images
- Make java 11 images default
- Change to pester 5.3
- Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
- Ensure that the pull request title represents the desired changelog entry
- Please describe what you did
- Ensure you have provided tests - that demonstrates feature works or fixes the issue
- Remove java 8 images - Make java 11 images default - Change to pester 5.3 - Add ltsc2022 images for nano and windowsservercore
timja
approved these changes
Sep 21, 2022
timja
changed the title
Co-authored-by: Tim Jacomb <21194782+timja@users.noreply.github.com>
Co-authored-by: Tim Jacomb <21194782+timja@users.noreply.github.com>
Co-authored-by: Tim Jacomb <21194782+timja@users.noreply.github.com>
Co-authored-by: Tim Jacomb <21194782+timja@users.noreply.github.com>
timja
approved these changes
Sep 21, 2022
MarkEWaite
requested changes
Sep 21, 2022
There was a problem hiding this comment.
Thanks very much for doing this! I think that the latest-jdk8 and alpine-jdk8 line need to be removed from README.md as well.
Likewise, the README.md example for alpine that mentions alpine3.16-jdk8 should be revised to alpine3.16-jdk11.
Can we also update the title of the pull request to "Drop Java 8"?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.