-
-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch Windows images to AdoptOpenJDK + Add Git and Git LFS to Windows Images #113
Conversation
slide
commented
Mar 28, 2020
- Use AdoptOpenJDK instead of plain OpenJDK
- Fix issues with passwords expiring
- Fix user creation issue
- Add Git and Git LFS
- Update versions
- Add tests
- Use AdoptOpenJDK instead of plain OpenJDK - Fix issues with passwords expiring - Fix user creation issue - Add Git and Git LFS - Update versions - Add tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, but I am unable to test it because I don't have access to necessary infrastructure. What have the results been during testing and how has it behaved?
It passes all the tests that the Linux container has. I am still working on bringing up a full local testing environment to test it. Do you have details on how you test things in your test environment? |
I'm not sure that my local environment will be any help. The public portion of my local environment is described in my lts-with-plugins branch. That includes The private portion of the local environment includes credentials and agents and jobs which require credentials and agents. Some of those agents have docker, but none of them are able to run Windows docker images (I'm not that modern yet). |
Updated to WIP to do some more testing locally |
I did some more extensive testing with some maven builds and so forth and things look good, so I am happy with this. |
That's great. Thanks so much! Approved to merge! |