Add automatic tests to the project

[krufab]

Added tests to the project, as per issue #100

[slide]

The problem is that you aren't a trusted contributor, so the CI will not use your Jenkinsfile changes.

[oleg-nenashev]

I am fine with introducing some smoke tests in the repository. OTOH it might be preferable to consider doing real integration tests. It might require using a more advanced test framework, e.g. for putting Jenkins into testcontainers

[krufab]

@oleg-nenashev, there is an integration test in jnlp-slave.
I agree integration tests would be useful as well. However they might come later on...

@slide , i'll revert the build.sh so that the tests can be executed

[slide]

@krufab I was not saying that you should revert build.sh, I am just telling you why the CI is failing. What I can do is submit a shadow PR with your same changes so that the CI will actually run using the Jenkinsfile changes, would that be ok with you?

[krufab]

@slide, I guess it's ok, yes

[slide]

@krufab See #102

[krufab]

@slide, Bats doesn't seem to be installed on the test server. I reverted the build.sh file, removed make tests and now it builds. You can run the tests on your local machine and check if they are ok. When the build server will be able to run the tests, I'll re-enable them.

[slide]

If you look at the master docker repo, you can see that bats is a submodule. That would be the way to go here too.

[slide]

I pulled in all the latest changes into my duplicate PR so we can see the Jenkinsfile changes in action

[slide]

#102 is passing for all the checks including the tests

[krufab]

Is it ok this PR or is there anything to change?

[slide]

I am happy with this, if @oleg-nenashev has no objections, I think it can be merged. I will look at adding some simple pester based tests for the Windows side.

[oleg-nenashev]

Thanks!