[FIXED JENKINS-32033] Support for multiple domain controllers #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresrc
reviewed
Sep 16, 2016
| @@ -518,7 +518,8 @@ public DirContext bind(String principalName, String password, List<SocketInfo> l | |||
| newProps.put("java.naming.ldap.attributes.binary","tokenGroups objectSid"); | |||
| newProps.put("java.naming.ldap.factory.socket",TrustAllSocketFactory.class.getName()); | |||
| newProps.putAll(props); | |||
| NamingException error = null; | |||
| NamingException namingException = null; | |||
| javax.naming.AuthenticationException authenticationException = null; | |||
There was a problem hiding this comment.
You can use BadCredentialsException here, as it seems the only subtype used.
| // if all the attempts failed | ||
| throw new BadCredentialsException("Either no such user '"+principalName+"' or incorrect password", error); | ||
| if (authenticationException !=null ) { | ||
| throw new BadCredentialsException("Either no such user '" + principalName + "' or incorrect password", authenticationException); |
There was a problem hiding this comment.
You can throw the previously created one if you want.
| throw new BadCredentialsException("Either no such user '" + principalName + "' or incorrect password", authenticationException); | ||
| } else { | ||
| throw new BadCredentialsException("Either no such user '" + principalName + "' or incorrect password", namingException); | ||
| } |
|
I do not think that this was a good idea as implemented - it can lead to a user locking out their account with a single typos in the password. |
|
I guess that because if you fail, you will be failling consecutively on all the domain controllers, what can make the user to be locked. Is this right? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows to use multiple domain controllers - even with multiple domains.
@jtnord @andresrc