Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New line issues in tests #167

Closed
ngx472 opened this issue Oct 23, 2022 · 2 comments
Closed

New line issues in tests #167

ngx472 opened this issue Oct 23, 2022 · 2 comments
Labels
Milestone

Comments

@ngx472
Copy link

ngx472 commented Oct 23, 2022

Hi

Just installed on Windows and several test failed.
e.g. issue162_NumberFormattingParsing
The issue is that the following string has CRLF as line ends
final var string = GPX.Writer.DEFAULT.toString(gpx);
Whereas the expected value happens to have LF only (depends on the IDE setup and whether the file was touched and saved)
The solution would be to compare while ignoring line endings.
I believe it should be a feature of junit but team disagrees junit-team/junit5#2394

Thanks
Ngx

@jenetics
Copy link
Owner

This can be fixed by using AssertJ and use

org.assertj.core.api.Assertions
    .assertThat("asdf")
    .isEqualToIgnoringNewLines("sdf");

instead the native TestNG assertion.

@jenetics jenetics added the bug label Oct 24, 2022
@jenetics jenetics added this to the v3.0.2 milestone Oct 25, 2022
jenetics added a commit that referenced this issue Nov 6, 2023
jenetics added a commit that referenced this issue Nov 6, 2023
@jenetics
Copy link
Owner

jenetics commented Nov 6, 2023

Merged into r3.1.0.

@jenetics jenetics closed this as completed Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants