Establishing the Development Workflow #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In case anyone is wondering, the similarities between this and Raanan Weber's BJS repository are intentional; the goal is to establish the foundation for building an ES6 web application using BJS, whereas Raanan's repository is oriented towards TypeScript |
Closed
RaananW
approved these changes
Feb 10, 2021
jelster
added a commit
that referenced
this pull request
Feb 13, 2021
Squashed Merge that includes these additions and changes * simplify .gitignore * Add common webpack config, placeholder dirs and files * Align approach with RW's TS approach. Fix scripts to use webpack configs * refactor webpack config, create canvas in index * including prod webpack config in updates * Adapt start scene snippet into Class * Capture camera, env into StartScene class * convert from class to component. Export createStartScene * Add landing page markup * Tweak landing page styles and markup * tweak CSS * remove source map from prod builds * remove devtool (sourcemap) option * Tighten up import statements to use tree-shaking Before: 8.91 MiB After: 3.11 MiB * Change to preview v5 of BJS packages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds basic repository content and configuration for the application.
-
npm run scriptsforstart,build, andlintOpening PR now to allow early feedback