Urgent - IOS crash when enableHybridAppEvents is enabled #745

[regevbr]

Urgent - IOS crash when enableHybridAppEvents is enabled #745

[peterpeterparker]

@regevbr Thx for the PR, don't have time before tonight but could have a look later

And Android, something to do?

[regevbr]

It works on android just fine.
The problem occurs in the WKWebView only which enforces that no 2 script handlers will have the same name.

[regevbr]

I do believe that the issue should really be fixed in the Facebook SDK but it will take forever to be fixed there. I will open an issue on their side as well

[peterpeterparker]

Thx for the confirmation 👍

I'll merge this and release a fix tonight

If u still have time to try v4.1.0 as discussed that would be interesting, I'm asking myself if the issue is here since a bit or if it's related to the Facebook SDK upgrade, as they, Fb, doesn't display anything in their Changelog

[regevbr]

Sure thing.
Haha I will check later on today.
In any case here is the bug report in facebook -
https://developers.facebook.com/bugs/242837016595902/

[regevbr]

@peterpeterparker side note - this is my first time "writing" ocjC code so any comments and fix suggestions are welcome.

[regevbr]

@peterpeterparker this fails exactly the same in 4.1.0

[peterpeterparker]

@regevbr thx a lot for the feedback, I'm almost happy to hear that 😉

I check the rest tonight

[peterpeterparker]

PR has been merged and a new version of the plugin has been released to npm

thx @regevbr for the PR, quick fix and clearing that up with Facebook 👍

FYI @msencer this fix an issue which follows your PR #732