Skip to content
This repository has been archived by the owner on Oct 24, 2022. It is now read-only.

Update Facebook Android SDK for iOS v4.38.0 and Android to v4.38.1 #725

Closed
peterpeterparker opened this issue Nov 21, 2018 · 2 comments
Closed
Assignees

Comments

@peterpeterparker
Copy link
Collaborator

peterpeterparker commented Nov 21, 2018

Bug or feature request

[X] I'm reporting a feature request

Describe the Bug of feature request

Facebook has published v4.38.0 of both SDKs for Android and iOS the 23th October 2018
They also release v4.38.1 for Android on the 1th November 2018, I guess there was a bug in the Android version

https://developers.facebook.com/docs/android/change-log-4x
https://developers.facebook.com/docs/ios/change-log-4x

Therefore we could release a new version of the plugin referencing these last versions

Respectively v4.38.0 for iOS and v4.38.1 for Android

The Facebook iOS SDK release notes is not full of details but is described as:

Fixed

* Resolved Bitcode Failure for Xcode 10/iOS 12
* Various bug fixes

Maybe this "Bitcode" error is linked with #717 ? Let's see

UPDATE Actually the Facebook iOS version is also v4.38.1 there is just no release notes...Facebook communication quality style...I guess they released on the 1st November too to sync their version

@peterpeterparker peterpeterparker self-assigned this Nov 21, 2018
@peterpeterparker
Copy link
Collaborator Author

peterpeterparker commented Nov 21, 2018

BREAKING: The FBSDKMessengerShareKit has been removed from the Facebook SDK iOS but the plugin itself doesn't have any direct references on it, should be ok

@peterpeterparker
Copy link
Collaborator Author

Login and share tested with my app Xcode 10 / iOS simulator iPhone XS and on an Android v7 device. All ok

Lindsay-Needs-Sleep pushed a commit to miloproductionsinc/cordova-plugin-facebook-connect that referenced this issue Mar 7, 2020
Lindsay-Needs-Sleep pushed a commit to miloproductionsinc/cordova-plugin-facebook-connect that referenced this issue Mar 7, 2020
Lindsay-Needs-Sleep pushed a commit to miloproductionsinc/cordova-plugin-facebook-connect that referenced this issue Mar 7, 2020
Lindsay-Needs-Sleep pushed a commit to miloproductionsinc/cordova-plugin-facebook-connect that referenced this issue Mar 7, 2020
Lindsay-Needs-Sleep pushed a commit to miloproductionsinc/cordova-plugin-facebook-connect that referenced this issue Mar 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant