Skip to content
This repository has been archived by the owner on Oct 24, 2022. It is now read-only.

[Feature] Rename ANDROID_SDK_VERSION to FACEBOOK_ANDROID_SDK_VERSION #706

Closed
peterpeterparker opened this issue Sep 10, 2018 · 1 comment
Closed

[Feature] Rename ANDROID_SDK_VERSION to FACEBOOK_ANDROID_SDK_VERSION #706

peterpeterparker opened this issue Sep 10, 2018 · 1 comment
Assignees
@peterpeterparker
Labels
feature-request

Comments

@peterpeterparker
Copy link
Collaborator

peterpeterparker commented Sep 10, 2018 •
edited
Loading

Bug or feature request

[X] I'm reporting a feature request

Describe the Bug of feature request

The variable ANDROID_SDK_VERSION is confusing, specially when I'm tired like today. It isn't the value of the Android SDK version but it is the value of the Facebook SDK version for Android

Expected Behavior

We should rename ANDROID_SDK_VERSION to FACEBOOK_ANDROID_SDK_VERSION or FB_ANDROID_SDK_VERSION or FACEBOOK_SDK_VERSION_ANDROID etc.

Additional Context

Follow up: #705 and
#507
@peterpeterparker peterpeterparker self-assigned this Sep 10, 2018
@peterpeterparker peterpeterparker mentioned this issue Sep 10, 2018
Closed
peterpeterparker added a commit that referenced this issue Sep 13, 2018
@peterpeterparker
refactor(#706): Rename ANDROID_SDK_VERSION to FACEBOOK_ANDROID_SDK_VE…
114a93a 
…RSION
@peterpeterparker
Copy link
Collaborator Author

And the winner is FACEBOOK_ANDROID_SDK_VERSION

ANDROID_SDK_VERSION has been renamed in master with FACEBOOK_ANDROID_SDK_VERSION see commit 114a93a

This will be released with v2.5.0

Lindsay-Needs-Sleep pushed a commit to miloproductionsinc/cordova-plugin-facebook-connect that referenced this issue Mar 7, 2020
@peterpeterparker
refactor(jeduan#706): Rename ANDROID_SDK_VERSION to FACEBOOK_ANDROID_…
8b9e886 
…SDK_VERSION
Lindsay-Needs-Sleep pushed a commit to miloproductionsinc/cordova-plugin-facebook-connect that referenced this issue Mar 7, 2020
@peterpeterparker
refactor(jeduan#706): Rename ANDROID_SDK_VERSION to FACEBOOK_ANDROID_…
9e16b4a 
…SDK_VERSION
Lindsay-Needs-Sleep pushed a commit to miloproductionsinc/cordova-plugin-facebook-connect that referenced this issue Mar 7, 2020
@peterpeterparker
refactor(jeduan#706): Rename ANDROID_SDK_VERSION to FACEBOOK_ANDROID_…
9816fb7 
…SDK_VERSION
Lindsay-Needs-Sleep pushed a commit to miloproductionsinc/cordova-plugin-facebook-connect that referenced this issue Mar 7, 2020
@peterpeterparker
refactor(jeduan#706): Rename ANDROID_SDK_VERSION to FACEBOOK_ANDROID_…
781209f 
…SDK_VERSION
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@peterpeterparker peterpeterparker

Labels
feature-request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@peterpeterparker