Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Numerical comparison implemented #184

Merged
merged 4 commits into from
Jan 5, 2024
Merged

Conversation

GleammerRay
Copy link
Contributor

1st commit implements the compare function itself.

2nd commit implements _get_num() for filling in numerical values (e.g. num_10 for 10.0 and num_10,01 for 10.01).

Merge it if you wish.

One thing to note, I am getting the following warning:

PerformanceWarning: DataFrame is highly fragmented.  This is usually the result of calling `frame.insert` many times, which has poor performance.  Consider joining all columns at once using pd.concat(axis=1) instead. To get a de-fragmented frame, use `newframe = frame.copy()`
  self[key] = self[left] < self[right]

I am not sure when it started appearing but I don't think it was there before the second commit so it needs further testing. Other than that everything seems to be working properly, I kept my changes minimal.

@GleammerRay
Copy link
Contributor Author

GleammerRay commented Jan 4, 2024

Line 173 too long - split into two lines

Screenshot_20240104-092245.png

@GleammerRay
Copy link
Contributor Author

Apparently my formatting change broke syntax. Whoops! Had to fix that.

@jealous
Copy link
Owner

jealous commented Jan 5, 2024

No worry, just take your time.

@codecov-commenter
Copy link

Codecov Report

Attention: 23 lines in your changes are missing coverage. Please review.

Comparison is base (9cb82d7) 98.20% compared to head (4ef0909) 96.04%.

Files Patch % Lines
stockstats.py 36.11% 23 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #184      +/-   ##
==========================================
- Coverage   98.20%   96.04%   -2.16%     
==========================================
  Files           1        1              
  Lines        1001     1037      +36     
==========================================
+ Hits          983      996      +13     
- Misses         18       41      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jealous jealous merged commit 8b76182 into jealous:master Jan 5, 2024
3 of 5 checks passed
@jealous
Copy link
Owner

jealous commented Jan 5, 2024

Thanks for the contribution. I think I will update the readme, contributor and tests in a later PR.

@GleammerRay GleammerRay deleted the compare branch January 5, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants