[GH-122] Update calculation of middle
#129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The typical price or middle price is calculated by: ``` (high + low + close) / 3 ``` But it would be accurate if the data source has the `amount` that represents the total amount of capital traded in that period. Use `middle = amount / volume` when amout is available. Also fix some typos in the read me file. Add some utilities for dropping columns, head or tail. Add python 3.11 in CI and drop 3.9.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The typical price or middle price is calculated by:
But it would be accurate if the data source has the
amountthat represents the total amount of capital traded in that period. Usemiddle = amount / volumewhen amout is available.Also fix some typos in the read me file.
Add some utilities for dropping columns, head or tail.
Add python 3.11 in CI and drop 3.9.