copy should not modify data #124
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
... and sorry for the two commits, I forgot to delete a print type message and had already pushed my repo... |
|
Looks like there are some format issues in the code. |
|
Hi Cedric,
Could understand when converting column names to lowercase, but on other side there are some libs that require capitalized names when using them. Really bad that there is no standard for the naming issue for the columns.
Best from Bavaria,
Neutro2
From: Cedric Zhuang ***@***.***>
Reply to: jealous/stockstats ***@***.***>
Date: Tuesday, 4. October 2022 at 08:01
To: jealous/stockstats ***@***.***>
Cc: Neutro2 ***@***.***>, Author ***@***.***>
Subject: Re: [jealous/stockstats] copy should not modify data (PR #124)
Looks like there are some format issues in the code.
I change the column name to lower case because the calculation of some indicators requires specific columns like 'close' or 'high', 'low'. I am not sure if they still working when you have columns like 'Close' or 'High'.
—
Reply to this email directly, view it on GitHub<#124 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AZI6FFQRDVNVMJL4272VHNDWBPB2RANCNFSM6AAAAAAQ3WTI7U>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
thanks for your wonderful lib, really like it.
When using your lib together with other frameworks I run into the problem that a copy call in the other framework caused the column names to be renamed to lower case, which the other framework can't handle. I scanned your code and found that the copy function has this "feature" in it.
As I think a copy should not modify the data compared to the original one I introduced a lowerCase-Flag in wrap and retype causing copy to leave the column names as they are. With that modification I was able to run your StockDataFrame also with other frameworks like backtesting.py
Best regards,
Neutro2