Works for Gutenberg and option-pages #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Changed script to target `#wpwrap` if `#post` is not existing. `#wpwrap` exists on Gutenberg and option-pages. - Changed conditions whether the script will be enqueued or not. - Added filter `cmb2_conditionals_enqueue_script`. Possibility to skip or force enqueuing of the script. - Added filter `cmb2_conditionals_enqueue_script_src`. Possibility to change script source.
|
Thanks @jhotadhari |
jhotadhari
added a commit
to croox/generator-wp-dev-env
that referenced
this pull request
Apr 25, 2019
### subgenerator `assets` - possible to add script and/or style in frontend and/or admin. ### subgenerator `composerPackage` - change version of composerPackage `jcchavezs/cmb2-conditionals` to `dev-master`, pull request got merged jcchavezs/cmb2-conditionals#73
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#wpwrapif#postis not existing.#wpwrapexists on Gutenberg and option-pages.cmb2_conditionals_enqueue_script. Possibility to skip or force enqueuing of the script.cmb2_conditionals_enqueue_script_src. Possibility to change script source.might solve issues: