Skip to content

Commit

Permalink
Trim trailing whitespace and test on CI (python#104275)
Browse files Browse the repository at this point in the history
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
  • Loading branch information
2 people authored and jbower-fb committed May 8, 2023
1 parent 013469f commit ffa4d19
Show file tree
Hide file tree
Showing 13 changed files with 44 additions and 12 deletions.
3 changes: 3 additions & 0 deletions .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@
# GitHub
.github/** @ezio-melotti @hugovk

# pre-commit
.pre-commit-config.yaml @hugovk @AlexWaygood

# Build system
configure* @erlend-aasland @corona10

Expand Down
22 changes: 22 additions & 0 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
name: Lint

on: [push, pull_request, workflow_dispatch]

permissions:
contents: read

concurrency:
group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
cancel-in-progress: true

jobs:
lint:
runs-on: ubuntu-latest
timeout-minutes: 10

steps:
- uses: actions/checkout@v3
- uses: actions/setup-python@v4
with:
python-version: "3.x"
- uses: pre-commit/action@v3.0.0
7 changes: 7 additions & 0 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
repos:
- repo: https://github.com/pre-commit/pre-commit-hooks
rev: v4.4.0
hooks:
- id: check-yaml
- id: trailing-whitespace
types_or: [c, python, rst]
2 changes: 1 addition & 1 deletion Modules/_blake2/blake2module.h
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,6 @@
#endif // HAVE_LIBB2

// for secure_zero_memory(), store32(), store48(), and store64()
#include "impl/blake2-impl.h"
#include "impl/blake2-impl.h"

#endif // Py_BLAKE2MODULE_H
4 changes: 2 additions & 2 deletions Modules/_blake2/impl/blake2b-round.h
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@
\
row2l = _mm_roti_epi64(row2l, -24); \
row2h = _mm_roti_epi64(row2h, -24); \

#define G2(row1l,row2l,row3l,row4l,row1h,row2h,row3h,row4h,b0,b1) \
row1l = _mm_add_epi64(_mm_add_epi64(row1l, b0), row2l); \
row1h = _mm_add_epi64(_mm_add_epi64(row1h, b1), row2h); \
Expand All @@ -81,7 +81,7 @@
\
row2l = _mm_roti_epi64(row2l, -63); \
row2h = _mm_roti_epi64(row2h, -63); \

#if defined(HAVE_SSSE3)
#define DIAGONALIZE(row1l,row2l,row3l,row4l,row1h,row2h,row3h,row4h) \
t0 = _mm_alignr_epi8(row2h, row2l, 8); \
Expand Down
2 changes: 1 addition & 1 deletion Modules/_blake2/impl/blake2s-load-xop.h
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ buf = _mm_perm_epi8(t1, m3, _mm_set_epi32(TOB(3),TOB(2),TOB(1),TOB(7)) );
#define LOAD_MSG_8_3(buf) \
t0 = _mm_perm_epi8(m0, m2, _mm_set_epi32(TOB(6),TOB(1),TOB(0),TOB(0)) ); \
buf = _mm_perm_epi8(t0, m3, _mm_set_epi32(TOB(3),TOB(2),TOB(5),TOB(4)) ); \

#define LOAD_MSG_8_4(buf) \
buf = _mm_perm_epi8(m0, m1, _mm_set_epi32(TOB(5),TOB(4),TOB(7),TOB(2)) );

Expand Down
2 changes: 1 addition & 1 deletion Modules/_blake2/impl/blake2s-round.h
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,6 @@
LOAD_MSG_ ##r ##_4(buf4); \
G2(row1,row2,row3,row4,buf4); \
UNDIAGONALIZE(row1,row2,row3,row4); \

#endif

2 changes: 1 addition & 1 deletion Modules/_ctypes/_ctypes_test.c
Original file line number Diff line number Diff line change
Expand Up @@ -1036,7 +1036,7 @@ EXPORT (HRESULT) KeepObject(IUnknown *punk)

#ifdef MS_WIN32

// i38748: c stub for testing stack corruption
// i38748: c stub for testing stack corruption
// When executing a Python callback with a long and a long long

typedef long(__stdcall *_test_i38748_funcType)(long, long long);
Expand Down
2 changes: 1 addition & 1 deletion Modules/_testcapi/immortal.c
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#include "parts.h"

int verify_immortality(PyObject *object)
int verify_immortality(PyObject *object)
{
assert(_Py_IsImmortal(object));
Py_ssize_t old_count = Py_REFCNT(object);
Expand Down
4 changes: 2 additions & 2 deletions Modules/termios.c
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ termios_tcgetattr_impl(PyObject *module, int fd)
int r;

Py_BEGIN_ALLOW_THREADS
r = tcgetattr(fd, &mode);
r = tcgetattr(fd, &mode);
Py_END_ALLOW_THREADS
if (r == -1) {
return PyErr_SetFromErrno(state->TermiosError);
Expand Down Expand Up @@ -372,7 +372,7 @@ termios_tcgetwinsize_impl(PyObject *module, int fd)
#if defined(TIOCGWINSZ)
termiosmodulestate *state = PyModule_GetState(module);
struct winsize w;
int r;
int r;

Py_BEGIN_ALLOW_THREADS
r = ioctl(fd, TIOCGWINSZ, &w);
Expand Down
2 changes: 1 addition & 1 deletion Parser/tokenizer.c
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ static inline tokenizer_mode* TOK_GET_MODE(struct tok_state* tok) {
}
static inline tokenizer_mode* TOK_NEXT_MODE(struct tok_state* tok) {
assert(tok->tok_mode_stack_index >= 0);
assert(tok->tok_mode_stack_index + 1 < MAXFSTRINGLEVEL);
assert(tok->tok_mode_stack_index + 1 < MAXFSTRINGLEVEL);
return &(tok->tok_mode_stack[++tok->tok_mode_stack_index]);
}
#else
Expand Down
2 changes: 1 addition & 1 deletion Tools/msi/bundle/bootstrap/pch.h
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
// The license and further copyright text can be found in the file
// LICENSE.TXT at the root directory of the distribution.
// </copyright>
//
//
// <summary>
// Precompiled header for standard bootstrapper application.
// </summary>
Expand Down
2 changes: 1 addition & 1 deletion Tools/msi/bundle/bootstrap/resource.h
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@


// Next default values for new objects
//
//
#ifdef APSTUDIO_INVOKED
#ifndef APSTUDIO_READONLY_SYMBOLS
#define _APS_NEXT_RESOURCE_VALUE 102
Expand Down

0 comments on commit ffa4d19

Please sign in to comment.