Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write combining through flush batching #436

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Write combining through flush batching #436

wants to merge 1 commit into from

Conversation

dmlloyd
Copy link
Member

@dmlloyd dmlloyd commented Oct 17, 2023

Use a counter to track how many threads are waiting to write; only the last writer flushes.

I wrote this while waiting for a compilation to complete. Tests seem OK but I haven't done any perf analysis on this.

@dmlloyd
Write combining through flush batching
bfed0f0 
Use a counter to track how many threads are waiting to write; only the last writer flushes.
@dmlloyd
Copy link
Member Author

dmlloyd commented Oct 17, 2023 •
edited
Loading

Possible simpler alternative to #428. /cc @franz1981

@dmlloyd dmlloyd requested a review from jamezp October 17, 2023 14:14
jamezp
jamezp approved these changes Oct 17, 2023
View reviewed changes
Copy link
Member

@jamezp jamezp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This definitely looks simpler and makes sense to me.

@dmlloyd dmlloyd marked this pull request as ready for review May 3, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamezp jamezp jamezp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmlloyd @jamezp