Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RISCV64 TargetArchitecture #940

Closed
wants to merge 1 commit into from
Closed

Conversation

clamp03
Copy link

@clamp03 clamp03 commented Mar 25, 2024

It is for supporting RISCV64 in cecil
Add RISCV64 to TargetArchitecture and update checks for pe64

Part of dotnet/runtime#84834
cc @dotnet/samsung

It is for supporting RISCV64 in cecil
Add RISCV64 to TargetArchitecture and update to check for pe64
@clamp03
Copy link
Author

clamp03 commented Mar 26, 2024

@jbevain Could you please review this PR? It is for RISC-V architecture. Thank you.

@clamp03
Copy link
Author

clamp03 commented Apr 4, 2024

I collected error message in CI.
Is it caused by this PR? If then, could you please give any guide for me to fix the error?
Thank you.

Testhost process for source(s) '/home/runner/work/cecil/cecil/symbols/pdb/Test/bin/Debug/netcoreapp3.1/Mono.Cecil.Pdb.Tests.dll' exited with error: You must install or update .NET to run this application.
Testhost process for source(s) '/home/runner/work/cecil/cecil/rocks/Test/bin/Debug/netcoreapp3.1/Mono.Cecil.Rocks.Tests.dll' exited with error: You must install or update .NET to run this application.
Testhost process for source(s) '/home/runner/work/cecil/cecil/symbols/mdb/Test/bin/Debug/netcoreapp3.1/Mono.Cecil.Mdb.Tests.dll' exited with error: You must install or update .NET to run this application.
Testhost process for source(s) '/home/runner/work/cecil/cecil/symbols/pdb/Test/bin/Debug/netcoreapp3.1/Mono.Cecil.Pdb.Tests.dll' exited with error: You must install or update .NET to run this application.
Error: Process completed with exit code 1.

@jbevain Could you please help? Thank you.

@Numpsy
Copy link

Numpsy commented Apr 10, 2024

Is it caused by this PR? If then, could you please give any guide for me to fix the error?

Looks like the unit tests are trying to run on .NET Core 3.1, and the build agents don't have that installed by default any more?

@clamp03 clamp03 closed this Apr 15, 2024
@clamp03
Copy link
Author

clamp03 commented Apr 15, 2024

My issue fixed by dotnet/runtime#101038

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants