Skip to content

Commit

Permalink
Fix NullEventHandler overloads
Browse files Browse the repository at this point in the history
Fix some virtual methods of NullEventHandler that were apparently
intended to overload base class methods, but did not. Add override
keyword to prevent these getting out of sync again.
  • Loading branch information
mwoehlke-kitware authored and jbeder committed Nov 10, 2017
1 parent 58687ee commit 5a519a4
Showing 1 changed file with 12 additions and 12 deletions.
24 changes: 12 additions & 12 deletions util/parse.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -20,21 +20,21 @@ Params ParseArgs(int argc, char** argv) {

class NullEventHandler : public YAML::EventHandler {
public:
virtual void OnDocumentStart(const YAML::Mark&) {}
virtual void OnDocumentEnd() {}
void OnDocumentStart(const YAML::Mark&) override {}
void OnDocumentEnd() override {}

virtual void OnNull(const YAML::Mark&, YAML::anchor_t) {}
virtual void OnAlias(const YAML::Mark&, YAML::anchor_t) {}
virtual void OnScalar(const YAML::Mark&, const std::string&, YAML::anchor_t,
const std::string&) {}
void OnNull(const YAML::Mark&, YAML::anchor_t) override {}
void OnAlias(const YAML::Mark&, YAML::anchor_t) override {}
void OnScalar(const YAML::Mark&, const std::string&, YAML::anchor_t,
const std::string&) override {}

virtual void OnSequenceStart(const YAML::Mark&, const std::string&,
YAML::anchor_t) {}
virtual void OnSequenceEnd() {}
void OnSequenceStart(const YAML::Mark&, const std::string&, YAML::anchor_t,
YAML::EmitterStyle::value) override {}
void OnSequenceEnd() override {}

virtual void OnMapStart(const YAML::Mark&, const std::string&,
YAML::anchor_t) {}
virtual void OnMapEnd() {}
void OnMapStart(const YAML::Mark&, const std::string&, YAML::anchor_t,
YAML::EmitterStyle::value) override {}
void OnMapEnd() override {}
};

void parse(std::istream& input) {
Expand Down

0 comments on commit 5a519a4

Please sign in to comment.