Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for EOL Python 2.7 and 3.5 #36

Closed
hugovk opened this issue Feb 21, 2020 · 5 comments · Fixed by #68
Closed

Drop support for EOL Python 2.7 and 3.5 #36

hugovk opened this issue Feb 21, 2020 · 5 comments · Fixed by #68

Comments

@hugovk
Copy link
Member

hugovk commented Feb 21, 2020

Python 2.7 is EOL since 2020-01-01.

Python 3.5 is EOL since 2020-09-30.

After prettytable 1.0 has been released (#18), support for Python 2.7 and 3.5 will be dropped, and released as prettytable 2.0.0.

Prettytable 1.x will be the last to support Python 2.7 and 3.5, and will remain available on PyPI.

The python_requires metadata will help those with modern pip (v9+) get the newest version of prettytable that supports their Python version.

@hugovk hugovk pinned this issue Feb 21, 2020
@hugovk hugovk added the removal label Feb 21, 2020
@parth-verma
Copy link

Is this issue up for grabs?

@hugovk
Copy link
Member Author

hugovk commented Jul 17, 2020

Not yet, still pending the release of prettytable 1.0 (#18), which will be the last to support 2.7.

But thanks for asking!

@hugovk hugovk changed the title Drop support for EOL Python 2.7 Drop support for EOL Python 2.7 and 3.5 Oct 4, 2020
@hugovk
Copy link
Member Author

hugovk commented Oct 4, 2020

@parth-verma PrettyTable 1.0 is almost out the door, would you like to take this issue?

We can also drop 3.5 too.

A few things to do:

  • Update Trove classifiers
  • Add Programming Language :: Python :: 3 :: Only classifier
  • Update python_requires
  • Update tox.ini
  • Remove from CI
  • Update --target-version in .pre-commit-config.yaml

Also run pip install -U pyupgrade && pyupgrade **/*.py --py36-plus and add args: ["--py36-plus"] to pyupgrade in .pre-commit-config.yaml

@hugovk

This comment has been minimized.

@hugovk
Copy link
Member Author

hugovk commented Oct 11, 2020

Please see PR #68.

@hugovk hugovk unpinned this issue Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants