Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New PyPI release? #18

Closed
hugovk opened this issue Aug 7, 2019 · 24 comments
Closed

New PyPI release? #18

hugovk opened this issue Aug 7, 2019 · 24 comments
Labels
release Deploy and release

Comments

@hugovk
Copy link
Member

hugovk commented Aug 7, 2019

The last release on PyPI is 0.7.2 from Apr 7, 2013.

There's been a few fixes in the past 6 years, would it be possible to make a new release to PyPI?

Ping @flaper87

Thank you!

@vinayak-mehta
Copy link

@flaper87 Just bumping this in your inbox.

@geckon
Copy link

geckon commented Nov 13, 2019

This would actually be really nice. @flaper87, pretty please? :)

@hugovk
Copy link
Member Author

hugovk commented Nov 13, 2019

I see this project is part of JazzBand, which should be able to help get a release out.

@jezdez Looks like this project hasn't done the JazzBand checklist yet. Should we create an issue and then help get a release out?

@jezdez
Copy link
Member

jezdez commented Nov 13, 2019

Huh, you're right, odd. A while ago we had troubles with GitHub API-throttling us. FWIW, if we can get a release ready I'm happy to step in for release confirmation if there is no project lead.

@hugovk
Copy link
Member Author

hugovk commented Dec 17, 2019

I added a checklist: #22.

@luzik
Copy link

luzik commented Jan 24, 2020

Maybe it is possible to release package under another name ?

@flaper87
Copy link
Collaborator

Jeeeez, this ended up being filtered out by gmail. I am soooooo sorry about this. I'm happy to give access to the Pypi project to Jazzband. What should I do to make prettytable releasable by jazzband?

@jezdez
Copy link
Member

jezdez commented Jan 24, 2020

@flaper87 See #22 for the TODOs.

@flaper87
Copy link
Collaborator

@flaper87 See #22 for the TODOs.

Done! Sorry again for having missed these notifications :(

@hugovk
Copy link
Member Author

hugovk commented Feb 2, 2020

Once we get things ready in #22, I plan to make a new release.

As it's been a long time since the last release (0.7.2, Apr 7, 2013), I suggest to make a release of what's in current master.

What version number?

Changes since 0.7.2: 0.7.2...master

This release will include dropping EOL Python 2.4-2.6, 3.0-3.3 (#5) and 3.4 (#16). SemVer says to bump the major version, except 0.x is for initial development with no stable API, and anything may change. However, PrettyTable has been out for a long time, so we can take it that SemVer has not been in use.

I propose we use SemVer and make this release PrettyTable 1.0 as so much time has passed and because Python versions have been dropped.

Then, after release, I suggest dropping Python 2.7 and modernising the codebase, and releasing later with PrettyTable 2.0.

@hugovk hugovk pinned this issue Feb 2, 2020
@hugovk hugovk mentioned this issue Feb 2, 2020
@hugovk
Copy link
Member Author

hugovk commented Feb 21, 2020

I think we're ready to release!

@jezdez Please could you hook up the CI for Jazzband releases (#22)?

Alternatively, @flaper87 could make the release, or I'd be happy to do so if you could add me to PyPI? I'm also hugovk there.

I could also automate it to deploy to TestPyPI on merges to master, and to production PyPI for tags, like this.

@andrewgy8
Copy link
Member

andrewgy8 commented Jun 4, 2020

Any updates on the release? I can help out where necessary.

@hugovk
Copy link
Member Author

hugovk commented Jun 13, 2020

Ping @flaper87

@flaper87
Copy link
Collaborator

Ping @flaper87

I'll let @jezdez decide what the best next step is here. I've not been following this project for a bit or the jazzband processes for that matter.

I've done the steps in #22 that are required to pass this on.

I'll now remove myself as a maintainer of this project on pypi to reduce confusion and set expectations right. 😊🤗

@ericpre
Copy link

ericpre commented Jul 1, 2020

It sounds like @hugovk is keen to do the release but it doesn't seem to be listed as maintainer on pypi?

@hugovk
Copy link
Member Author

hugovk commented Sep 29, 2020

I've posted a request for help at jazzband/help#202. If nothing happens, another option to consider is a PEP 541 transfer.

@andrewgy8
Copy link
Member

andrewgy8 commented Sep 29, 2020

🤔 Correct me if Im wrong but I thought the whole point of Jazzband was so these sorts of things dont happen?

@hugovk
Copy link
Member Author

hugovk commented Sep 29, 2020

That is the idea, and it resolves many of the issues, but unfortunately we've hit a bottleneck in this particular area. See also jazzband/help#196.

@andrewgy8
Copy link
Member

👍 Yeah, doesn't seem easy. Well, if anyone needs help, Im willing to give some of my time!

@flaper87
Copy link
Collaborator

@hugovk I have added you as a maintainer of PrettyTable on Pypi!

This may be the fastest way. If you have time, it would be great to setup CI as you described in jazzband/help#202

@hugovk
Copy link
Member Author

hugovk commented Sep 30, 2020

@flaper87 Thank you!

I don't have access to the Jazzband backend to set up CI releasing there (only Jazzband roadies can), but I can automate deploys to TestPyPI on merges to master, and to production PyPI for tags, using https://github.com/pypa/gh-action-pypi-publish. I'll get that set up and plan to get a new release out in a week or so!

@hugovk
Copy link
Member Author

hugovk commented Sep 30, 2020

OK, I've made PR #57 to automate deploys, but looks like we've hit another roadie-only blocker: we'll need to put PyPI API tokens into this repo's secret settings. I can create them but I don't have access to this repo's settings.

If it can't be resolved, one option would be to move this repo to another organisation.

But before considering that, the immediate solution is to manually twine upload, and I'll also make a release checklist for this.

@hugovk
Copy link
Member Author

hugovk commented Oct 4, 2020

Good news!

Seven years after the last release, PrettyTable 1.0.0 is out!

image

https://pypi.org/project/prettytable/1.0.0/

Thanks everyone for your help and patience!

@hugovk hugovk closed this as completed Oct 4, 2020
@hugovk hugovk unpinned this issue Oct 4, 2020
@andrewgy8
Copy link
Member

Great work and persistence @hugovk ! 🍪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Deploy and release
Projects
None yet
Development

No branches or pull requests

8 participants