Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --no-allow-unsafe option to compile #1265

Merged
merged 2 commits into from
Dec 30, 2020
Merged

Add --no-allow-unsafe option to compile #1265

merged 2 commits into from
Dec 30, 2020

Conversation

jdufresne
Copy link
Member

In future versions of pip-tools, the --allow-unsafe behavior will used
by default. Adding the --no-allow-unsafe option now allows users to
continue using the old behavior in a backward compatible way.

Refs #989

Contributor checklist
  • Provided the tests for the changes.
  • Gave a clear one-line description in the PR (that the maintainers can add to CHANGELOG.md on release).
  • Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

In future versions of pip-tools, the --allow-unsafe behavior will used
by default. Adding the --no-allow-unsafe option now allows users to
continue using the old behavior in a backward compatible way.

Refs #989
@jdufresne jdufresne added this to the 5.5.0 milestone Dec 4, 2020
@codecov
Copy link

codecov bot commented Dec 4, 2020

Codecov Report

Merging #1265 (f044a25) into master (bc9695c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1265   +/-   ##
=======================================
  Coverage   99.66%   99.66%           
=======================================
  Files          37       37           
  Lines        2980     2980           
  Branches      331      331           
=======================================
  Hits         2970     2970           
  Misses          5        5           
  Partials        5        5           
Impacted Files Coverage Δ
piptools/scripts/compile.py 100.00% <ø> (ø)
tests/test_cli_compile.py 100.00% <ø> (ø)
tests/test_utils.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc9695c...f044a25. Read the comment docs.

Copy link
Member

@atugushev atugushev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@atugushev atugushev merged commit 4ac1490 into jazzband:master Dec 30, 2020
@jdufresne jdufresne deleted the no-allow-unsafe branch December 30, 2020 15:56
@atugushev atugushev added the enhancement Improvements to functionality label Dec 30, 2020
This was referenced Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvements to functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants