Replace Travis CI with GitHub Actions #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No problem, rebased! |
jezdez
approved these changes
Nov 25, 2020
| @@ -14,7 +14,8 @@ py | |||
| pyflakes | |||
| pytest | |||
| pytest-cov | |||
| sphinxcontrib-spelling | |||
| sphinxcontrib-spelling<5.0.0; python_version == '2.7' | |||
| sphinxcontrib-spelling; python_version > '2.7' | |||
| @@ -313,7 +313,7 @@ class Counter(models.Base): | |||
| counter2 = Counter(value='2') | |||
| assert isinstance(counter2.value, int) | |||
| assert counter2.value == 2 | |||
| if not six.PY3: | |||
| if six.PY2: | |||
|
I'm wondering why no action is run for this PR though? |
|
I think it needs at least some workflow file in the repo before it's activated for the very first time. |
|
|
|
This is the passing build from my fork: https://github.com/hugovk/jsonmodels/actions/runs/383955129 |
|
Gotcha, let's merge this. Thanks again @hugovk! |
|
I've re-enabled the checks requirement (test builds and codecov) in the master branch protection settings. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Travis CI has a new pricing model which places limits on open source.
Many projects are moving to GitHub Actions instead, including Jazzband projects:
This is based on jazzband/contextlib2#26.
It drops support for Python 3.3 and 3.4 because GitHub Actions doesn't fully support them. They're EOL anyway.
Python 3.9 support is also added.
No more mention of Travis CI in the codebase:
$ git grep -i travis $TODO:
JAZZBAND_RELEASE_KEYto the repo secrets.continuous-integration/travis-ciandcoverage/coverallsfrom required checks