-
-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Travis CI with GitHub Actions #137
Conversation
No problem, rebased! |
@@ -14,7 +14,8 @@ py | |||
pyflakes | |||
pytest | |||
pytest-cov | |||
sphinxcontrib-spelling | |||
sphinxcontrib-spelling<5.0.0; python_version == '2.7' | |||
sphinxcontrib-spelling; python_version > '2.7' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
@@ -313,7 +313,7 @@ class Counter(models.Base): | |||
counter2 = Counter(value='2') | |||
assert isinstance(counter2.value, int) | |||
assert counter2.value == 2 | |||
if not six.PY3: | |||
if six.PY2: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😬
I'm wondering why no action is run for this PR though? |
I think it needs at least some workflow file in the repo before it's activated for the very first time. |
|
This is the passing build from my fork: https://github.com/hugovk/jsonmodels/actions/runs/383955129 |
Gotcha, let's merge this. Thanks again @hugovk! |
I've re-enabled the checks requirement (test builds and codecov) in the master branch protection settings. |
Travis CI has a new pricing model which places limits on open source.
Many projects are moving to GitHub Actions instead, including Jazzband projects:
This is based on jazzband/contextlib2#26.
It drops support for Python 3.3 and 3.4 because GitHub Actions doesn't fully support them. They're EOL anyway.
Python 3.9 support is also added.
No more mention of Travis CI in the codebase:
$ git grep -i travis $
TODO:
JAZZBAND_RELEASE_KEY
to the repo secrets.continuous-integration/travis-ci
andcoverage/coveralls
from required checks