-
-
Notifications
You must be signed in to change notification settings - Fork 477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update GitHub Actions migration to match other Jazzband projects. #769
Conversation
- adds caching - splits test matrix by django version - drop support for Python 3.5 (EOL)
Codecov Report
@@ Coverage Diff @@
## master #769 +/- ##
=======================================
Coverage 97.47% 97.47%
=======================================
Files 18 18
Lines 992 992
Branches 151 151
=======================================
Hits 967 967
Misses 12 12
Partials 13 13 Continue to review full report at Codecov.
|
It appears that every build is running twice? Is that intentional? |
@ThePumpingLemma Yeah, that's expected (even if a bit broad) since we're tracking both pushes to all branches (including the pull request branch) as well as other pull request events (by default "opened", "synchronize" and "reopened"). Those pull request events basically just describe other things that can happen to a pull request during its lifetime (and after its first lifetime for that matter) so that the tests are always run in whatever state the PR is in. The "synchronize" event type happens when a pull request's branch is updated with the tracking branch (e.g. the main/master branch is merged in). Hope that explains the reasoning. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jezdez!
Description
I'm currently porting all of Jazzband projects to GitHub Actions and this
is a minor update to #738 (thank you @ThePumpingLemma!).
It does drop Python 3.5 support though since that's EOL'd now.
It also adds Jazzband releases again after it was removed in #738. @rossmechanic Please make sure to not remove it again.
Related Issue
#738
https://github.com/orgs/jazzband/projects/1
Motivation and Context
This is only needed to keep Jazzband projects close in how they are configured.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
make format
command to format my codeAUTHORS.rst
CHANGES.rst
Original text I've used in other PRs relating to the migration to GitHub Actions:
Travis CI has a new pricing model which places limits on open source.
Many projects are moving to GitHub Actions instead, including Jazzband projects:
This is based on jazzband/contextlib2#26.
TODO:
JAZZBAND_RELEASE_KEY
to the repo secrets.