Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditions addition to insert_row #1359

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rgs258
Copy link

@rgs258 rgs258 commented Jun 26, 2024

Conditions the addition to insert_row within create_historical_record_m2ms in order to respect excluded_field_kwargs via self.field_excluded_kwargs.

This change necessarily undoes the addition of through_model_field_names = [f.name for f in through_model._meta.fields] which is not compatible with the api of self.field_excluded_kwargs.

Description

See #1358

Related Issue

#1358

Motivation and Context

#1358

How Has This Been Tested?

Yes, I run it in prod.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have run the pre-commit run command to format and lint.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have added my name and/or github handle to AUTHORS.rst
  • I have added my change to CHANGES.rst
  • All new and existing tests passed.

…ord_m2ms` in order to respect `excluded_field_kwargs` via `self.field_excluded_kwargs`.

This change necessarily undoes the addition of `through_model_field_names = [f.name for f in through_model._meta.fields]` which is not compatible with the api of `self.field_excluded_kwargs`.
@rgs258
Copy link
Author

rgs258 commented Jun 28, 2024

@ddabble FYI and THANK YOU for maintaining this great project!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant