Fix double-escaping of the curl and Python example code #709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These code fragments are escaped when they are substituted into the `silk/request.html` template, so they should not be escaped an extra time when they are constructed.
for more information, see https://pre-commit.ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #709 +/- ##
==========================================
+ Coverage 86.76% 86.80% +0.04%
==========================================
Files 52 52
Lines 2115 2115
==========================================
+ Hits 1835 1836 +1
+ Misses 280 279 -1 ☔ View full report in Codecov by Sentry. |
50-Course
approved these changes
Mar 24, 2024
There was a problem hiding this comment.
Hello again @SpecLad, this patch looks good to me, and ready for release.
One more pass from the team and we are good to go, @Archmonger can you take a look at this?
CC: @albertyw
|
Sure I can review this tomorrow, but I'm technically not an admin for this repo. |
Archmonger
approved these changes
Mar 24, 2024
There was a problem hiding this comment.
Seems like fairly simple and straightforward fix. I'm good with this change.
The proper course of action would be to wait for a project lead such as @albertyw to approve this.
BrhmDnsK263
approved these changes
Jun 5, 2024
albertyw
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These code fragments are escaped when they are substituted into the
silk/request.htmltemplate, so they should not be escaped an extra time when they are constructed.Fixes #688.