Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare next release #342

Merged
merged 71 commits into from
Jul 18, 2024
Merged

Prepare next release #342

merged 71 commits into from
Jul 18, 2024

Conversation

johnraz
Copy link
Collaborator

@johnraz johnraz commented May 2, 2024

Some things that need to be done before develop is ready:

  • Changelog should be updated
  • Base on the changelog update a version should be promoted
  • A task to generate the documentation and publish the github page should be put in place
  • Access to the pypi registry should be gained

Keep this PR in draft until the above are done

@James1345 @giovannicimolin

belugame and others added 30 commits January 31, 2022 16:28
fix  django.db.migrations.exceptions.IrreversibleError: Operation <RunPython <function cleanup_tokens at 0x0000027CCB764820>> in knox.0006_auto_20160818_0932 is not reversible error when python manage,py migrate knox zero on django 4.0.4
Changes made were done to make the README.md easy to read.
* Allowed usage of custom AuthToken based on knox.AbstractAuthToken

* moved get_token_model() to models, updated the docs

Co-authored-by: Khalidm98 <khalid.refaat@gmail.com>
…etup

test: Set up pre-commit hooks and fix quality nits
updates:
- [github.com/PyCQA/isort: 5.11.5 → 5.12.0](PyCQA/isort@5.11.5...5.12.0)
@giovannicimolin
Copy link
Contributor

@johnraz Oh, that's a neat tool!

I need to catch up the changelog with the merges though, there's quite a few things that were merged but are missing from there (all minor things or fixes though).
We still haven't got Pypi access, so I'm thinking of creating a mirror repo just to unblock releases until that is solved.

@vasilistotskas
Copy link

Any updates on this?

@johnraz
Copy link
Collaborator Author

johnraz commented Jun 12, 2024

Any updates on this?

The fact that the MR is not progressing should give you a hint…

We are still trying to gain shared access to the pypi repository and need to find some time to address the points above.

update AuthTokenManager to support custom values
@max-wittig
Copy link
Contributor

@johnraz Hi! Seems like we didn't get updates for 2 years now. We would really like to have more consistent updates as its a critical component. Is there anything that we can support here?

@James1345
Copy link
Member

@johnraz Jazzband has been invited to the pypi repo, is there anything else needed from me to get that handed over so this can progress without me?

@johnraz
Copy link
Collaborator Author

johnraz commented Jul 1, 2024

@max-wittig the only supportive thing to do at this stage is to be patient.

@James1345 that’s awesome, I’m not sure if full access to the github repo was already given or not to jazzband but if that’s the case than nothing else should be needed! Thanks a lot for taking the time.

@giovannicimolin
Copy link
Contributor

@James1345 Thanks for the Pypi access!

@johnraz I now have maintainer access on Pypi and can deploy new versions.
We now need to do some cleanup, update the changelog and we'll be good to deploy a new version.

@johnraz
Copy link
Collaborator Author

johnraz commented Jul 1, 2024

Awesome I'll try to free up some time in the coming days - if you don't see me move feel free to take action too 😉

@johnraz johnraz mentioned this pull request Jul 1, 2024
@johnraz johnraz mentioned this pull request Jul 1, 2024
@johnraz
Copy link
Collaborator Author

johnraz commented Jul 1, 2024

@giovannicimolin please see #355 it adds the changelog and should fix the conflict...

@giovannicimolin
Copy link
Contributor

@johnraz Nice! I reviewed and merged the PR.
We missed changing the version in setup.py though.

I can do that when figuring out how to release a new version this week though!

@johnraz johnraz marked this pull request as ready for review July 1, 2024 15:21
@johnraz
Copy link
Collaborator Author

johnraz commented Jul 1, 2024

Thanks @giovannicimolin , I moved this MR from draft to ready ;)

max-wittig and others added 2 commits July 9, 2024 20:11
I've increased the version to major, as this kind of a big change asks for one.

Fixes #357
docs(changelog): bump to 5.0.0, add token warning
Copy link
Contributor

@giovannicimolin giovannicimolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Looks good, let's get this release going.

@giovannicimolin giovannicimolin merged commit 4651b6a into master Jul 18, 2024
17 checks passed
@vasilistotskas
Copy link

pip version 5?

@max-wittig
Copy link
Contributor

Thanks for the release! I love it that you put the warning right on top where people can see them!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.