Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python 3.10 support and classifiers #623

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Andrew-Chen-Wang
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Oct 7, 2021

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.28%. Comparing base (820262e) to head (6b4fd87).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #623   +/-   ##
=======================================
  Coverage   70.28%   70.28%           
=======================================
  Files          26       26           
  Lines        1097     1097           
  Branches      249      249           
=======================================
  Hits          771      771           
  Misses        288      288           
  Partials       38       38           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good work

setup.cfg Outdated Show resolved Hide resolved
setup.cfg Outdated Show resolved Hide resolved
@Andrew-Chen-Wang
Copy link
Member Author

sorry was using nano and the tab system might've just been wonky

setup.cfg Outdated
@@ -12,6 +12,7 @@ classifiers =
Framework :: Django :: 2.2
Framework :: Django :: 3.0
Framework :: Django :: 3.1
Framework :: Django :: 3.2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

more spacing fix is needed in both

@bertonha
Copy link
Contributor

if this branch is rebased with latest master it should pass

@Andrew-Chen-Wang
Copy link
Member Author

We'll need to drop hyper for Python 3.10 support, which probably comes from pywebpush

@bertonha
Copy link
Contributor

bertonha commented Jan 25, 2022

We'll need to drop hyper for Python 3.10 support, which probably comes from pywebpush

hyper comes from apns2

I did this ugly and bad #648 just to demonstrate the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants