Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternate provider factory #121

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ppython
Copy link

@ppython ppython commented Nov 9, 2016

This patch provide an optional alternative to the current core.py/provider_factory method by setting an extra variable in the settings.

You could customize where the PAYMENTS_VARIANTS settings should be (DB instead of settings for exemple); have as many "stripe settings", isolated from one another.

I tried to provide as well a doc with this patch "doc/alternate_provider_factory.rst", it's a draft and unlinked from the other, as-is.

I needed to be able to configure a 'per entity in the DB' PAYMENT_VARIANTS list through the backend of my Django project. This patch helped me resolve this problem.

@codecov-io
Copy link

codecov-io commented Nov 9, 2016

Current coverage is 78.13% (diff: 28.57%)

Merging #121 into master will decrease coverage by 0.21%

@@             master       #121   diff @@
==========================================
  Files            29         29          
  Lines          1682       1688     +6   
  Methods           0          0          
  Messages          0          0          
  Branches        193        194     +1   
==========================================
+ Hits           1318       1319     +1   
- Misses          260        264     +4   
- Partials        104        105     +1   

Powered by Codecov. Last update 0582f98...15cf762

@esistgut
Copy link
Contributor

This is a feature I really need, any progress on the merge?

@patrys
Copy link
Contributor

patrys commented Nov 21, 2016

No progress here to report. We're thinking about an entirely different API for a future release of django-payments to better support other use cases.

@ppython
Copy link
Author

ppython commented Nov 22, 2016

Excellent, though do you have an estimation of the target release date? weeks/months? (to keep track)

@WhyNotHugo
Copy link
Member

I know it's been years, but I'd love to see this happen.

Would an updated PR for this be accepted?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants