Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: split model modules #467

Merged
merged 5 commits into from
Dec 7, 2023
Merged

refactor: split model modules #467

merged 5 commits into from
Dec 7, 2023

Conversation

jacobjove
Copy link
Contributor

I'm helping!

Checklist

  • I have double checked that there are no unrelated changes in this pull request (old patches, accidental config files, etc.)
  • I have created at least one test case for the changes I have made
  • I have updated the documentation for the changes I have made
  • I have added my changes to the CHANGELOG.md

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Related issue(s)

Other Information

@Dresdn
Copy link
Contributor

Dresdn commented Dec 2, 2023

Nice @iacobfred! This has been a long-standing todo bugging me :)

Dresdn
Dresdn requested changes Dec 2, 2023
View reviewed changes
Copy link
Contributor

@Dresdn Dresdn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you switch back to using the typing module for 3.8 compatibility?

eav/models/attribute.py Outdated Show resolved Hide resolved
@jacobjove jacobjove requested a review from Dresdn December 5, 2023 16:50
@Dresdn
Copy link
Contributor

Dresdn commented Dec 7, 2023

Thank you for the contribution @iacobfred!

@Dresdn Dresdn merged commit e1bc667 into jazzband:master Dec 7, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dresdn Dresdn Awaiting requested review from Dresdn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jacobjove @Dresdn