Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow using multiple eav filters in QuerySet #414

Merged
merged 3 commits into from
Sep 8, 2023

Conversation

Dresdn
Copy link
Contributor

@Dresdn Dresdn commented Sep 7, 2023

I'm helping!

Checklist

  • I have double checked that there are no unrelated changes in this pull request (old patches, accidental config files, etc.)
  • I have created at least one test case for the changes I have made
  • I have updated the documentation for the changes I have made
  • I have added my changes to the CHANGELOG.md

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Related issue(s)

Closes #395

Other Information

Credit to @dasith2190

@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Merging #414 (3cdb6bf) into master (ec957dc) will increase coverage by 0.53%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #414      +/-   ##
==========================================
+ Coverage   89.33%   89.87%   +0.53%     
==========================================
  Files          23       23              
  Lines         769      770       +1     
  Branches      106      106              
==========================================
+ Hits          687      692       +5     
+ Misses         58       56       -2     
+ Partials       24       22       -2     
Files Changed Coverage Δ
eav/queryset.py 93.10% <100.00%> (+1.79%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Dresdn Dresdn changed the title Issue 395 Allow using multiple eav filters in QuerySet Sep 8, 2023
@Dresdn Dresdn merged commit d2ceab3 into jazzband:master Sep 8, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: Cannot combine a unique query with a non-unique query.
1 participant