Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use SplitDateTimeField for date Attribute types #321

Merged
merged 4 commits into from
Feb 10, 2023

Conversation

Dresdn
Copy link
Contributor

@Dresdn Dresdn commented Feb 10, 2023

I'm helping!

Checklist

  • I have double checked that there are no unrelated changes in this pull request (old patches, accidental config files, etc.)
  • I have created at least one test case for the changes I have made
  • I have updated the documentation for the changes I have made
  • I have added my changes to the CHANGELOG.md

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Related issue(s)

Fixes #261

Other Information

@codecov
Copy link

codecov bot commented Feb 10, 2023

Codecov Report

Merging #321 (c55c9a8) into master (d6a05a0) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #321      +/-   ##
==========================================
- Coverage   90.14%   90.12%   -0.02%     
==========================================
  Files          22       22              
  Lines         771      770       -1     
  Branches      138      138              
==========================================
- Hits          695      694       -1     
  Misses         52       52              
  Partials       24       24              
Impacted Files Coverage Δ
eav/forms.py 78.87% <100.00%> (-0.30%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Dresdn Dresdn merged commit a98c0d2 into jazzband:master Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'list' object does not have attribute 'strip' when storing attribute of type 'date'
1 participant