fix mediabackup not working with S3 storages #498
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Archmonger
requested changes
Jan 29, 2024
Archmonger
reviewed
Jan 29, 2024
| from django.core.files.storage import storages | ||
| from django.db import DEFAULT_DB_ALIAS | ||
|
|
||
| return storages[DEFAULT_DB_ALIAS] |
There was a problem hiding this comment.
Can you confirm if this works when replacing with the following?
try:
...
except Exception:
from django.core.files.storage import default_storage
return default_storage()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR (feature, enhancement, bug fix, etc.)
Description
Please include a summary of the change and which issue is fixed.
Fixes # (issue)
Why should this be added
Explain value.
Checklist