fix: restore tempfile created 0 B #464
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #464 +/- ##
==========================================
+ Coverage 92.15% 92.20% +0.04%
==========================================
Files 16 16
Lines 676 680 +4
Branches 141 142 +1
==========================================
+ Hits 623 627 +4
Misses 30 30
Partials 23 23
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
rsommerard
force-pushed
the
fix/0b-tempfile
branch
from
2d84111
to
76cd4ec
Compare
|
Hey @rsommerard Can you please add tests for this edge case? |
|
Marking as draft until tests are added. |
|
Closing due to failing tests and no response from author. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR (feature, enhancement, bug fix, etc.)
Description
File coming from external server like FTP are not well restored due to this error:
Restore tempfile created 0 BI don't know if the fix is the good way to do it.
Fixes #463