Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dbrestore on SQLite #383

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

Fix dbrestore on SQLite #383

wants to merge 7 commits into from

Conversation

Lokkook
Copy link

@Lokkook Lokkook commented Feb 11, 2021

Adding @rgaiacs changes about restoring to sqlite db with newlines

Bug fix

Description

This change fix a pb when restoring fields that contains newlines.

Adding @rgaiacs changes about restoring to sqlite db with newlines
@johnthagen
Copy link
Contributor

Related to #254 #258

@codecov
Copy link

codecov bot commented Apr 27, 2022

Codecov Report

Merging #383 (20d7287) into master (d187830) will decrease coverage by 0.57%.
The diff coverage is 64.70%.

@@            Coverage Diff             @@
##           master     #383      +/-   ##
==========================================
- Coverage   90.87%   90.30%   -0.58%     
==========================================
  Files          19       19              
  Lines         855      866      +11     
  Branches      173      176       +3     
==========================================
+ Hits          777      782       +5     
- Misses         42       45       +3     
- Partials       36       39       +3     
Impacted Files Coverage Δ
dbbackup/db/sqlite.py 82.60% <64.70%> (-7.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d187830...20d7287. Read the comment docs.

@Archmonger Archmonger changed the title Update sqlite.py Fix SQLite dbrestore support Apr 28, 2022
@Archmonger Archmonger added bug Bugs that need to get fixed. db/sqlite high priority Priority issues labels Apr 28, 2022
@Archmonger Archmonger changed the title Fix SQLite dbrestore support Fix dbrestore on SQLite Apr 29, 2022
@Archmonger Archmonger marked this pull request as draft April 29, 2022 07:50
@Archmonger
Copy link
Contributor

Archmonger commented Apr 29, 2022

@johnthagen You mentioned something about the functional tests on this repo being iffy. Do you think that might be the reason why the test_create_dump_with_newline in this PR doesn't appear to run (according to the codecov hits)?

Unrelated note, I confirmed at least one issue on Windows appears to be related to gpg support. See dbbackup/tests/utils/add_public_gpg.

@johnthagen
Copy link
Contributor

You mentioned something about the functional tests on this repo being iffy.

I don't fully recall.

Unrelated note, I confirmed at least one issue on Windows appears to be related to gpg support.

Maybe *nix specific tests like gpg could be marked as skipped on Windows: https://docs.pytest.org/en/7.1.x/how-to/skipping.html#skipping-test-functions

@Archmonger
Copy link
Contributor

I'd need to confirm whether they should be skipped or not. It's very possible these tests failing is an indication that encryption support is broken on Windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugs that need to get fixed. db/sqlite high priority Priority issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants