-
-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix dbrestore on SQLite #383
base: master
Are you sure you want to change the base?
Conversation
Adding @rgaiacs changes about restoring to sqlite db with newlines
Codecov Report
@@ Coverage Diff @@
## master #383 +/- ##
==========================================
- Coverage 90.87% 90.30% -0.58%
==========================================
Files 19 19
Lines 855 866 +11
Branches 173 176 +3
==========================================
+ Hits 777 782 +5
- Misses 42 45 +3
- Partials 36 39 +3
Continue to review full report at Codecov.
|
@johnthagen You mentioned something about the functional tests on this repo being iffy. Do you think that might be the reason why the Unrelated note, I confirmed at least one issue on Windows appears to be related to |
I don't fully recall.
Maybe *nix specific tests like |
I'd need to confirm whether they should be skipped or not. It's very possible these tests failing is an indication that encryption support is broken on Windows. |
Adding @rgaiacs changes about restoring to sqlite db with newlines
Bug fix
Description
This change fix a pb when restoring fields that contains newlines.