Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

logger.info in management command dbrestore is too slow (utils.handle_size) #517

Open
jahazieldom opened this issue Apr 16, 2024 · 0 comments
Open

logger.info in management command dbrestore is too slow (utils.handle_size) #517

jahazieldom opened this issue Apr 16, 2024 · 0 comments
Labels
feature-request

Comments

@jahazieldom
Copy link
Contributor

Feature description

Management command dbrestore is too slow, I can see that a lot of the time it is due to this log:

self.logger.info("Restore tempfile created: %s", utils.handle_size(input_file))

I'm using Google Cloud Storage and the file size of the dump is 4 GiB

Alternatives options

Can use filehandle.size instead filehandle.tell() in utils.handle_size
@jahazieldom jahazieldom changed the title Log inside management command dbrestore is too slow (utils.handle_size) Log in management command dbrestore is too slow (utils.handle_size) Apr 16, 2024
@jahazieldom jahazieldom changed the title Log in management command dbrestore is too slow (utils.handle_size) logger.info in management command dbrestore is too slow (utils.handle_size) Apr 16, 2024
jahazieldom added a commit to jahazieldom/django-dbbackup that referenced this issue Jun 19, 2024
@jahazieldom
jazzband#517 Use filehandle.size in utils.handle_size
c377c32
Archmonger pushed a commit that referenced this issue Jun 28, 2024
@jahazieldom
#517 Use filehandle.size in utils.handle_size (#518)
6187954
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jahazieldom