Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ugettext_lazy breaks with Django 4.0 alpha 1 release #399

Closed
awtimmering opened this issue Sep 25, 2021 · 27 comments
Closed

ugettext_lazy breaks with Django 4.0 alpha 1 release #399

awtimmering opened this issue Sep 25, 2021 · 27 comments

Comments

@awtimmering
Copy link

Can a release be made including #342 (replace ugettext_lazy with gettext_lazy)?

The newly released Django 4.0 alpha 1 has dropped ugettext_lazy.
The latest release of django-dbbackup still uses ugettext_lazy. This was addressed in #342 however not yet released, meaning of dbbackup run into errors and can not try their applications on Django 4.0 alpha 1 until this is done.

@johnthagen
Copy link
Contributor

Related to #381

@johnthagen
Copy link
Contributor

johnthagen commented Dec 12, 2021

Should also include wheels in the next release: #382

@johnthagen
Copy link
Contributor

If @jonathan-s is no longer maintaining this project, there may need to be a new community fork. There have been no commits for a year.

@pulse-mind
Copy link

If @jonathan-s is no longer maintaining this project, there may need to be a new community fork. There have been no commits for a year.

May be @jonathan-s can give us is idea about that ?

I'm interesting by going forward on this subject

@johnthagen
Copy link
Contributor

@pulse-mind Probably what needs to happen is someone volunteers to fork, merges in the necessary 4.0 compatibility patches, and publishes under an available name on PyPI such as django-dbbackup2. We can then advertise the fork on the issues in this repo to make it more discoverable. To be a "friendly" fork, we offer to merge changes back to django-dbbackup if maintainers re-appear or are willing to add new maintainers.

@pulse-mind
Copy link

@johnthagen why using a fork, it would be better to have the rights on the repo to do the job?!?
Then it would be possible to accept push requests, release versions...
I do not know how to publish on PyPi, if it is automatic when we create a version...?

@johnthagen
Copy link
Contributor

why using a fork, it would be better to have the rights on the repo to do the job?!?

Ideally yes, but if the maintainers are not responsive, there is no one to grant anyone new permissions to this repo.

@pulse-mind
Copy link

why using a fork, it would be better to have the rights on the repo to do the job?!?

Ideally yes, but if the maintainers are not responsive, there is no one to grant anyone new permissions to this repo.

Agree with you.
We can let one week to @jonathan-s to answer ?

May be some others users like @ZuluPro may know something ?

Is it possible to know the list of the members who have this kind of permissions ?

@ZuluPro
Copy link
Contributor

ZuluPro commented Dec 15, 2021

Hi everyone,
I'm sorry for my absence and my late reply.

I absolutely don't have the time to maintain DBBackup but it would be a pleasure to pass the ownership to someone with more time and knowledge.

Who's volunteer to maintain DBBackup ?

@johnthagen
Copy link
Contributor

I have enough time to do very basic maintenance (keep dbbackup working on latest Django / remove deprecation warnings / etc.) I'm currently doing the same for django-solo.

If you also want to grant ability to upload to PyPI my username there is: https://pypi.org/user/johnthagen/

@pulse-mind
Copy link

pulse-mind commented Dec 15, 2021

Thank you @johnthagen and @ZuluPro !! If you need help, let me know!

@Archmonger
Copy link
Contributor

Archmonger commented Dec 16, 2021

Hey @ZuluPro

I'm coming over from the Jazzband GitHub organization. We're currently the biggest organization for OSS Django packages.

I would be interested in taking temporary ownership for this repo and doing the necessary changes to get it transferred to Jazzband.

Including myself, there are various members that I'm sure would support maintenance for this repo.

@ZuluPro
Copy link
Contributor

ZuluPro commented Dec 19, 2021

Hi @Archmonger
Yes Jazzband iis a good idea, I think a bit of maitenance and cleaning should be good before submit Dbbackup.

Hi @johnthagen
Thank you for you time and attention,
I give you the rights for the Github Organization and the the Pypi repo.

But like @Archmonger suggested, it could be a good thing to transfer it to Jazzband

@johnthagen
Copy link
Contributor

I also agree Jazzband would be a very good long term plan.

Thanks @ZuluPro!

@Archmonger
Copy link
Contributor

I also agree Jazzband would be a very good long term plan.

Thanks @ZuluPro!

Let me know if you need any support on this!

@ZuluPro
Copy link
Contributor

ZuluPro commented Dec 19, 2021

Hi @Archmonger
Can you contact me on my mail box anthony.monthe[a]gmail.com ??
So I can give you grants on Pypi

@johnthagen
Copy link
Contributor

I'm currently working on cleaning things up for a release.

Let me know if you need any support on this!

I think another issue with a checklist of what needs to be done to get this repo ready for submission to JazzBand, would be very helpful.

@johnthagen
Copy link
Contributor

@ZuluPro I'm pulling together a 4.0.0b0 release that I'd like to push to PyPI for people to test out. I can't seem to upload and when I look at my projects on PyPI, I don't see django-dbbackup. I also don't see myself listed as a maintainer at https://pypi.org/project/django-dbbackup/.

Would you mind double checking if I was invited to the PyPI project? I'm also not sure where I would "see" invites. I've looked through all of the pages on my PyPI account and don't see anything about django-dbbackup.

My profile: https://pypi.org/user/johnthagen/

@banagale
Copy link

Bump. @ZuluPro Would you please look in on this? Django 4.0 is released.

@Archmonger
Copy link
Contributor

I have the ability to create releases and will do so once @johnthagen tags a solid build

@banagale
Copy link

I see, @johnthagen Do you see that @Archmonger is prepared to publish a release?

@Archmonger Can you clarify whether you consider a beta release, like the one @johnthagen mentioned above (4.0.0b0) as suitable for publishing on pypi? Or when you say "solid build" do you mean a tag of something that is ready for release?

@Archmonger
Copy link
Contributor

I just confirmed that john had not been invited to PyPI, so I've sent him an invite.

I am currently not a maintainer on the GitHub repo though so I'll need @johnthagen to add me as one if I am to tag releases in the future.

@banagale
Copy link

@Archmonger Thank you for looking at that. I appreciate any further cooperation needed to get a Django 4.0-compatible release out the door.

@Archmonger
Copy link
Contributor

As a temporary workaround, you can install pip install via git git+https://github.com/django-dbbackup/django-dbbackup.git

ex pip install git+https://github.com/django-dbbackup/django-dbbackup.git

@johnthagen
Copy link
Contributor

4.0.0b0 has been released: https://pypi.org/project/django-dbbackup/4.0.0b0/ 🎉

I just confirmed that john had not been invited to PyPI, so I've sent him an invite.

Thanks!

I am currently not a maintainer on the GitHub repo though so I'll need @johnthagen to add me as one if I am to tag releases in the future.

@Archmonger You have been invited as an owner to the django-dbackup organization

I have the ability to create releases and will do so once @johnthagen tags a solid build

4.0.0b0 has been tagged in GitHub, but as a pre-release it doesn't show up in the main page UI, so it might not have been obvious it had been tagged before: https://github.com/django-dbbackup/django-dbbackup/releases/tag/4.0.0b0

@phroiland
Copy link

I know this issue is closed, but any word on getting an official release?

Appreciate the beta version.

@johnthagen
Copy link
Contributor

Please follow #415. Unfortunately we are still waiting for the original maintainers to give access to the ReadTheDocs site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants