add HugePage info to memory and topology #374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaypipes
requested changes
Sep 17, 2024
pkg/memory/memory.go
Outdated
| // Default system huge pages size, in bytes | ||
| DefaultHugePageSize uint64 `json:"default_huge_page_size"` | ||
| // Amount of memory, in bytes, consumed by huge pages of all sizes. | ||
| HugeTLBSize int64 `json:"huge_tlb_size"` |
There was a problem hiding this comment.
the TLB is the lookaside buffer used for looking up the huge page physical location from a virtual address. It's also a Linux-specific thing and I'd prefer to keep the Area struct system-agnostic as much as possible.
How about we call this field TotalHugePageBytes?
pkg/memory/memory.go
Outdated
| SupportedPageSizes []uint64 `json:"supported_page_sizes"` | ||
| Modules []*Module `json:"modules"` | ||
| SupportedPageSizes []uint64 `json:"supported_page_sizes"` | ||
| // Default system huge pages size, in bytes |
There was a problem hiding this comment.
Suggested change
| // Default system huge pages size, in bytes | |
| // Default system huge page size, in bytes |
pkg/memory/memory.go
Outdated
| @@ -29,6 +29,15 @@ type Module struct { | |||
| Vendor string `json:"vendor"` | |||
| } | |||
|
|
|||
| // HugePage describes huge page info | |||
| type HugePage struct { | |||
There was a problem hiding this comment.
Let's call this struct HugePageAmounts since it's not describing the huge page itself but rather a set of distinct finite amounts of huge pages of a particular size within a memory area.
Signed-off-by: Maksym Aryefyev <maksym.aryefyev@gmail.com>
Signed-off-by: Maksym Aryefyev <maksym.aryefyev@gmail.com>
jaypipes
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#371 fix
Add huge page info to Topology and Memory functionality.